Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a new API named WorkloadRebalancer to support rescheduling #4841

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Introduce a new API named WorkloadRebalancer to support rescheduling #4841

merged 1 commit into from
Apr 23, 2024

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Apr 17, 2024 •
edited
Loading

What type of PR is this?

/kind api-change
/kind feature

What this PR does / why we need it:

Introduce a new API named WorkloadRebalancer to support rescheduling

Which issue(s) this PR fixes:

Fixes part of #4840

Special notes for your reviewer:

DO NOT MERGE until the following PR have been merged:

Does this PR introduce a user-facing change?:

Introduce a new API named WorkloadRebalancer to support rescheduling.

@karmada-bot karmada-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. labels Apr 17, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 17, 2024
@chaosi-zju chaosi-zju mentioned this pull request Apr 17, 2024
Closed
@chaosi-zju
Copy link
Member Author

@XiShanYongYe-Chang @RainbowMango could you please take some time to help review it?

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.98%. Comparing base (aded7c0) to head (c600991).
Report is 6 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4841      +/-   ##
==========================================
- Coverage   52.99%   52.98%   -0.01%     
==========================================
  Files         250      250              
  Lines       20420    20421       +1     
==========================================
- Hits        10821    10820       -1     
- Misses       8880     8882       +2     
  Partials      719      719
Flag Coverage Δ
unittests 52.98% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju chaosi-zju force-pushed the reschedule-api branch 3 times, most recently from 9c565c9 to 2cd253b Compare April 17, 2024 08:43
@RainbowMango
Copy link
Member

Please fix the comments and remove the ResourceBinding part as it's in #4848.

@chaosi-zju chaosi-zju changed the title Add an imperative API to support rescheduling Introduce a new API named WorkloadRebalancer to support rescheduling Apr 20, 2024
@chaosi-zju chaosi-zju force-pushed the reschedule-api branch 2 times, most recently from ed44bd0 to 5805103 Compare April 20, 2024 15:07
@chaosi-zju
Copy link
Member Author

Please fix the comments and remove the ResourceBinding part as it's in #4848.

this PR should rebase after #4848 merged, the new introduced field in ResourceBinding is also useful in this PR.

@RainbowMango
Copy link
Member

Please rebase and fix failing tests.

@chaosi-zju chaosi-zju force-pushed the reschedule-api branch 3 times, most recently from f15a99a to e00213f Compare April 22, 2024 03:45
@chaosi-zju
Copy link
Member Author

chaosi-zju commented Apr 22, 2024 •
edited
Loading

Please rebase and fix failing tests.

done, ready to review @RainbowMango @XiShanYongYe-Chang

I have finished testing this PR too.

@chaosi-zju chaosi-zju mentioned this pull request Apr 22, 2024
Closed
RainbowMango
RainbowMango reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review is on going, I'm still looking at the status part.

pkg/apis/apps/v1alpha1/workloadrebalancer_types.go Outdated Show resolved Hide resolved
pkg/apis/apps/v1alpha1/workloadrebalancer_types.go Outdated Show resolved Hide resolved
pkg/apis/apps/v1alpha1/workloadrebalancer_types.go Outdated Show resolved Hide resolved
pkg/apis/apps/v1alpha1/workloadrebalancer_types.go Outdated Show resolved Hide resolved
@chaosi-zju chaosi-zju force-pushed the reschedule-api branch 2 times, most recently from a845acb to 635209a Compare April 22, 2024 11:48
@chaosi-zju
Introduce a new API named WorkloadRebalancer to support rescheduling.
c600991 
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
RainbowMango
RainbowMango reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Leave LGTM to @XiShanYongYe-Chang for final decision.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@XiShanYongYe-Chang
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
@karmada-bot karmada-bot merged commit 6e5a602 into karmada-io:master Apr 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango left review comments

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

@jrkeen jrkeen Awaiting requested review from jrkeen

@lfbear lfbear Awaiting requested review from lfbear

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chaosi-zju @codecov-commenter @RainbowMango @karmada-bot @XiShanYongYe-Chang