Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kubernetes dependencies to v1.29.4 #4884

Merged
merged 5 commits into from
May 6, 2024

Conversation

RainbowMango
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR bumps Kubernetes dependencies to v1.29.4.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 29, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.14%. Comparing base (5e1191f) to head (64f2cc6).

Files Patch % Lines
pkg/controllers/status/common.go 0.00% 1 Missing ⚠️
pkg/controllers/status/work_status_controller.go 0.00% 1 Missing ⚠️
...er/customized/declarative/configmanager/manager.go 0.00% 1 Missing ⚠️
...esourceinterpreter/default/native/reflectstatus.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4884      +/-   ##
==========================================
+ Coverage   53.13%   53.14%   +0.01%     
==========================================
  Files         251      251              
  Lines       20417    20415       -2     
==========================================
+ Hits        10848    10849       +1     
+ Misses       8855     8853       -2     
+ Partials      714      713       -1     
Flag Coverage Δ
unittests 53.14% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member Author

This PR is now blocked by the issue that karmada-metrics-adapter failed to startup due to:

E0429 02:35:01.375275       1 options.go:104] Unable to construct metrics adapter: unable to construct lister client config to initialize provider: open /var/run/secrets/kubernetes.io/serviceaccount/token: no such file or directory
E0429 02:35:01.375304       1 run.go:74] "command failed" err="unable to construct lister client config to initialize provider: open /var/run/secrets/kubernetes.io/serviceaccount/token: no such file or directory"

Update custom-metrics-apiserver to latest

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
Adopt Kubernetes #118653, introduce VolumeResourceRequirements
Remove APIPriorityAndFairness feature gates from
karmada-aggregated-apiserver.

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@RainbowMango
Copy link
Member Author

Another error is:

-bash-5.0# kubectl apply -f examples/customresourceinterpreter/apis/workload.example.io_workloads.yaml 
The CustomResourceDefinition "workloads.workload.example.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

…e.io is invalid: metadata.annotations: Too long: must have at most 262144 bytes

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@RainbowMango
Copy link
Member Author

This is the minimum changes for updating Kubernetes dependencies to v1.29.4 :)
After this we still need to update dependencies like:

  • controller-runtime
  • metrics-adapter
  • Golang version
  • and So on.

@RainbowMango RainbowMango added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 6, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit ae0d3fa into karmada-io:master May 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants