-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sigs.k8s.io/cluster-api to v1.7.1 #4923
Conversation
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4923 +/- ##
==========================================
- Coverage 53.14% 53.14% -0.01%
==========================================
Files 251 251
Lines 20415 20415
==========================================
- Hits 10850 10849 -1
- Misses 8852 8853 +1
Partials 713 713
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Please @XiShanYongYe-Chang help to take another look, I'm not sure if there is E2E test for cluster API feature.
/assign @XiShanYongYe-Chang
The cluster-api has not been added to the E2E environment. Therefore, there is no E2E to monitor this function. We can test it by referring to the steps in #594 |
get it, thanks. I'll test it later and post the verification results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How is the test result? |
Clusters created by (base) ➜ karmada git:(main) ✗ kubectl get cluster
NAME CLUSTERCLASS PHASE AGE VERSION
capi-quickstart quick-start Provisioned 12h v1.29.2
(base) ➜ karmada git:(main) ✗ kubectl --context karmada-apiserver get cluster
NAME VERSION MODE READY AGE
capi-quickstart v1.29.2 Push True 12h
member1 v1.27.3 Push True 16h
member2 v1.27.3 Push True 16h
member3 v1.27.3 Pull True 16h |
OK. got it. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump sigs.k8s.io/cluster-api to v1.7.1
Which issue(s) this PR fixes:
Parts of #4907
Special notes for your reviewer:
Does this PR introduce a user-facing change?: