-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump golangci-lint to v1.58.0 #4930
Bump golangci-lint to v1.58.0 #4930
Conversation
since this is the last task, so i think you can fix the issue with |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4930 +/- ##
=======================================
Coverage 53.18% 53.19%
=======================================
Files 252 252
Lines 20510 20510
=======================================
+ Hits 10909 10911 +2
+ Misses 8882 8880 -2
Partials 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
test/helper/request.go
Outdated
@@ -82,6 +82,7 @@ func DoRequest(urlPath string, token string) (int, error) { | |||
|
|||
// #nosec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not need this line anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's no longer needed. I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this PR need to wait for #4934?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
5be8db3
to
309c677
Compare
ObjectMeta: metav1.ObjectMeta{ | ||
Annotations: map[string]string{corev1.ServiceAccountUIDKey: uuid}, | ||
}, | ||
Data: map[string][]byte{key: []byte(value)}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remind me why ObjectMeta and Data are required here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function retainSecretServiceAccountToken
is used to retain the uid
and data
of observed secret when its type is SA. Therefore the input secret of its test case should contain ObjectMeta
(for uid) and Data
. The previous implementations didn't actually test the ability to retain uid
and data
, because ObjectMeta
and Data
weren't used when creating test case secrets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks.
@XiShanYongYe-Chang I'm not sure if you have to revisit this test at #4940 after this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump golangci-lint to v1.58.0. The following tasks are included:
golangci-lint
version inhack/verify-staticcheck.sh
run.skip-dirs
is deprecated, useissues.exclude-dirs
instead.run.skip-dirs-use-default
is deprecated, useissues.exclude-dirs-use-default
instead.Which issue(s) this PR fixes:
Fixes #4907
Special notes for your reviewer:
Does this PR introduce a user-facing change?: