-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve access to member-cluster resources that use pb/json protocol … #4936
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
def8cb4
to
7541be5
Compare
Signed-off-by: wangxiaofei67 <wangxiaofei67@jd.com>
7541be5
to
f4c8fc5
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4936 +/- ##
==========================================
+ Coverage 53.05% 53.17% +0.11%
==========================================
Files 250 252 +2
Lines 20396 20520 +124
==========================================
+ Hits 10822 10911 +89
- Misses 8855 8884 +29
- Partials 719 725 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest |
@wangxf1987: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Just retested it manually. Sorry for the inconvenience. The Another way to retrigger the test is to rebase PR and force push again. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wangxf1987 You may need to rebase first to bring in the changes in the master branch over time
@@ -19,8 +19,10 @@ package util | |||
import ( | |||
"context" | |||
"fmt" | |||
"k8s.io/apimachinery/pkg/runtime" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to sort the import
@@ -227,6 +229,25 @@ func BuildClusterConfig(clusterName string, | |||
} | |||
} | |||
|
|||
if clusterConfig.ContentType != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be split into two functions to solve the problem of excessive circle complexity?
@wangxf1987 Do you still need it? |
…and allow users to set qps, burst values.
What type of PR is this?
/kind feature
What this PR does / why we need it:
In the large cluster, reasonable qps and burst values need to be set when accessing resources. to improve speed to resources.And use the pb/jsion protocol to improve the communication speed of sub-clusters for resources.
We design a compatibiity processing. when a null pointer is passed in qps and burst are not set.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: