Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e for remedy #5007

Merged

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented May 31, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add e2e for the remedy feature.

Which issue(s) this PR fixes:
Part of #4658

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: changzhen <changzhen5@huawei.com>
Signed-off-by: changzhen <changzhen5@huawei.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 31, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 31, 2024
@XiShanYongYe-Chang
Copy link
Member Author

Hi @Vacant2333, can you help take a look?
cc @Vacant2333

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.30%. Comparing base (a8c6723) to head (87a1938).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5007   +/-   ##
=======================================
  Coverage   53.30%   53.30%           
=======================================
  Files         253      253           
  Lines       20560    20560           
=======================================
  Hits        10960    10960           
  Misses       8875     8875           
  Partials      725      725           
Flag Coverage Δ
unittests 53.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vacant2333
Copy link
Contributor

/assign

Copy link
Contributor

@Vacant2333 Vacant2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
@XiShanYongYe-Chang
Copy link
Member Author

cc @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, Vacant2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
@karmada-bot karmada-bot merged commit b8bf8fc into karmada-io:master Jun 6, 2024
12 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the add-e2e-for-remedy branch June 7, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants