Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Artifact HUB badge #5051

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Add Artifact HUB badge #5051

merged 1 commit into from
Jun 17, 2024

Conversation

B1F030
Copy link
Contributor

@B1F030 B1F030 commented Jun 14, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #5048

Special notes for your reviewer:
See the preview here.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 14, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 14, 2024
Signed-off-by: B1F030 <b1fzhang@gmail.com>
@B1F030
Copy link
Contributor Author

B1F030 commented Jun 14, 2024

cc @zhzhuang-zju @RainbowMango

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.22%. Comparing base (bbf37c1) to head (a989131).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5051      +/-   ##
==========================================
- Coverage   28.22%   28.22%   -0.01%     
==========================================
  Files         632      632              
  Lines       43434    43434              
==========================================
- Hits        12261    12258       -3     
- Misses      30278    30280       +2     
- Partials      895      896       +1     
Flag Coverage Δ
unittests 28.22% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Leave LGTM to @zhzhuang-zju for another look.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2024
@zhzhuang-zju
Copy link
Contributor

/lgtm thanks.

@RainbowMango
Copy link
Member

/lgtm
The command should be in a separate line. @zhzhuang-zju

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
@karmada-bot karmada-bot merged commit 6b4bef0 into karmada-io:master Jun 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants