-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define top level Permission for dockerhub-latest-chart.yml (latest chart to Dockerhub) work flow #5082
Define top level Permission for dockerhub-latest-chart.yml (latest chart to Dockerhub) work flow #5082
Conversation
Signed-off-by: aditya7302 <aditya7302@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5082 +/- ##
=========================================
Coverage ? 28.20%
=========================================
Files ? 632
Lines ? 43571
Branches ? 0
=========================================
Hits ? 12289
Misses ? 30384
Partials ? 898
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dd6cd9a
to
9fa11b9
Compare
/ok-to-test |
|
||
permissions: | ||
contents: read # Needed to fetch the repository contents. | ||
packages: write # Needed to push the chart to DockerHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working for push to the ghcr.io, and i think we done't need it due to we push to the dockerhub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- permissions:
--- contents: read # Needed to fetch the repository contents.
--- packages: write # Needed to push the chart to DockerHub.
+++ permissions: read-all
I think we can ack the permissions of read-all .
9fa11b9
to
f9a1585
Compare
@liangyuanpeng I have removed the redundant permission. |
…art to Dockerhub) workflow Signed-off-by: aditya7302 <aditya7302@gmail.com>
f9a1585
to
5b4fb63
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangyuanpeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR have two commit, and 39a667e is open at #5081, so it mistakenly caused PR #5081 to be merged as well when this PR is merged. But the PR #5081 (comment) still have some comment, @aditya7302 could you open a new PR for it? Thanks. |
@liangyuanpeng I have opened a new PR #5126 for PR #5081 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #5048
Special notes for your reviewer:
Does this PR introduce a user-facing change?: