Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define top level Permission for dockerhub-latest-chart.yml (latest chart to Dockerhub) work flow #5082

Conversation

aditya7302
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #5048

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: aditya7302 <aditya7302@gmail.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 22, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@5e35497). Learn more about missing BASE report.
Report is 30 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5082   +/-   ##
=========================================
  Coverage          ?   28.20%           
=========================================
  Files             ?      632           
  Lines             ?    43571           
  Branches          ?        0           
=========================================
  Hits              ?    12289           
  Misses            ?    30384           
  Partials          ?      898           
Flag Coverage Δ
unittests 28.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aditya7302 aditya7302 force-pushed the dockerhub-latest-chart-token-permission branch from dd6cd9a to 9fa11b9 Compare June 22, 2024 07:54
@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2024
@liangyuanpeng
Copy link
Contributor

/ok-to-test
/retest


permissions:
contents: read # Needed to fetch the repository contents.
packages: write # Needed to push the chart to DockerHub.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working for push to the ghcr.io, and i think we done't need it due to we push to the dockerhub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

---  permissions:
---  contents: read     # Needed to fetch the repository contents.
---  packages: write    # Needed to push the chart to DockerHub.

+++ permissions: read-all

I think we can ack the permissions of read-all .

@aditya7302
Copy link
Contributor Author

@liangyuanpeng I have removed the redundant permission.

…art to Dockerhub) workflow

Signed-off-by: aditya7302 <aditya7302@gmail.com>
@aditya7302 aditya7302 force-pushed the dockerhub-latest-chart-token-permission branch from f9a1585 to 5b4fb63 Compare July 1, 2024 15:32
@zhzhuang-zju
Copy link
Contributor

/lgtm
ask @liangyuanpeng to take another look

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2024
@liangyuanpeng
Copy link
Contributor

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
@karmada-bot karmada-bot merged commit 7aaea78 into karmada-io:master Jul 3, 2024
12 checks passed
@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Jul 3, 2024

This PR have two commit, and 39a667e is open at #5081, so it mistakenly caused PR #5081 to be merged as well when this PR is merged.

But the Files Changed only one file: .github/workflows/dockerhub-latest-chart.yml, this is the reason i approve it. somewhat strange.

PR #5081 (comment) still have some comment, @aditya7302 could you open a new PR for it? Thanks.

@aditya7302
Copy link
Contributor Author

@liangyuanpeng I have opened a new PR #5126 for PR #5081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants