Fix the bug in interpreting the replicas of Job #5095
Conversation
karmada-bot
added
the
size/XS
Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
whitewindmills
force-pushed
the
jobs-replicas
branch
from
fe648e0
to
bf9eaf0
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5095 +/- ##
=======================================
Coverage 28.22% 28.22%
=======================================
Files 632 632
Lines 43551 43554 +3
=======================================
+ Hits 12293 12294 +1
- Misses 30362 30364 +2
Partials 896 896
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/assign |
| // For fixed completion count Jobs, the actual number of pods running in parallel will not exceed the number of remaining completions. | ||
| // Higher values of .spec.parallelism are effectively ignored. | ||
| // More info: https://kubernetes.io/docs/concepts/workloads/controllers/job/ | ||
| completions := ptr.Deref[int32](job.Spec.Completions, replica) |
There was a problem hiding this comment.
Indeed. In my local test, when parallelism > completions, only completions number of jobs will be generated.
There was a problem hiding this comment.
So, we are trying to address the accuracy issue. Right?
Generally looks good to me, just a question need to confirm.
|
ping @RainbowMango |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
…-#5095-upstream-release-1.10 Automated cherry pick of #5095: Fix the bug in interpreting the replicas of Job
…-#5095-upstream-release-1.8 Automated cherry pick of #5095: Fix the bug in interpreting the replicas of Job
…-#5095-upstream-release-1.9 Automated cherry pick of #5095: Fix the bug in interpreting the replicas of Job
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: