-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(proposal): add docs for using cascading deletion #5101
base: master
Are you sure you want to change the base?
docs(proposal): add docs for using cascading deletion #5101
Conversation
7d688b9
to
09ad847
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5101 +/- ##
==========================================
+ Coverage 28.19% 28.90% +0.71%
==========================================
Files 631 632 +1
Lines 43482 43862 +380
==========================================
+ Hits 12258 12680 +422
+ Misses 30326 30267 -59
- Partials 898 915 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @CharlesQQ
Hi, guys @RainbowMango @chaunceyjiang @whitewindmills @zhy76 @buji-code @lcw2
We can discuss here to improve the resource deletion policy.
/assign |
0f2fb08
to
2653e9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this annotation have a knock-on effect on dependent resources?―that is, one adds such an annotation to his Deployment, will the annotation affect its dependent resources(like ConfigMap
)?
2653e9d
to
09c6d78
Compare
09c6d78
to
281dbbf
Compare
b9171d6
to
4ad9a83
Compare
5315523
to
fe04cdf
Compare
9c9f156
to
7153d46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also ask @RainbowMango to help take a look.
/cc @RainbowMango
7153d46
to
604716b
Compare
/assign @RainbowMango |
Equivalent to supporting both solution one and solution two | ||
|
||
### Solution comparison | ||
| Name | Supported control plane resources | Extend API resources | User learning cost | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get what is the different below the title "Supported control plane resources".
| Solution One | all resources | None | lowest | | ||
| Solution Two | resource template | PP/CPP/RB/CRB/WORK | lowest | | ||
| Solution Three | all resources | new CRD/WORK | Highest | | ||
| Solution Four | all resources | PP/CPP/RB/CRB/WORK | lower | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can highlight another comparison
like solution one can set the orphan
attribute at the granularity of each resource template, while solution two can only set the orphan` attribute at the granularity of policy. In 1 policy vs multi resource scene, we cann't execute orphan delete just by per resource.
604716b
to
e37b16b
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: chang.qiangqiang <chang.qiangqiang@immomo.com>
e37b16b
to
788e44a
Compare
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
part of #4709
Special notes for your reviewer:
Does this PR introduce a user-facing change?: