-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch openapi-gen from k8s.io/code-generator to k8s.io/kube-openapi #5111
Switch openapi-gen from k8s.io/code-generator to k8s.io/kube-openapi #5111
Conversation
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5111 +/- ##
==========================================
- Coverage 28.22% 28.21% -0.01%
==========================================
Files 632 632
Lines 43556 43556
==========================================
- Hits 12293 12290 -3
- Misses 30367 30369 +2
- Partials 896 897 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign @chaunceyjiang |
ping @chaunceyjiang |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested on Mac M1.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaunceyjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The
openapi-gen
has been removed from k8s.io/code-generator by kubernetes/kubernetes#123529 because it is redundant with the one in k8s.io/kube-openapi.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
We are going to bump Kubernetes dependencies to v1.30, this PR solves one of the blockers.
Does this PR introduce a user-facing change?: