set Minimum GITHUB_TOKEN permissions to github workflow #5123
Conversation
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/S
| @@ -41,6 +45,8 @@ jobs: | |||
| _output/release/${{ matrix.target }}-${{ matrix.os }}-${{ matrix.arch }}.tgz | |||
| _output/release/${{ matrix.target }}-${{ matrix.os }}-${{ matrix.arch }}.tgz.sha256 | |||
| release-crds-assests: | |||
| permissions: | |||
| contents: write # for softprops/action-gh-release to create GitHub release | |||
There was a problem hiding this comment.
following the doc,set the correct permission. https://github.com/softprops/action-gh-release?tab=readme-ov-file#permissions
/lgtm
|
leave approval to @RainbowMango |
|
/assign @RainbowMango |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5123 +/- ##
=======================================
Coverage 28.20% 28.21%
=======================================
Files 632 632
Lines 43571 43571
=======================================
+ Hits 12289 12292 +3
+ Misses 30385 30383 -2
+ Partials 897 896 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
set Minimum GITHUB_TOKEN permissions to github workflow
Which issue(s) this PR fixes:
Parts of #5048
Special notes for your reviewer:
Does this PR introduce a user-facing change?: