Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define top level Permission for lint-chart.yaml (Chart Lint) workflow #5137

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

aditya7302
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #5048

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: aditya7302 <aditya7302@gmail.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 4, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 4, 2024
@aditya7302
Copy link
Contributor Author

@zhzhuang-zju Sorry for creating multiple PR's and then closing them, I made some mistakes while resolving the conflicts.

Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@liangyuanpeng
Copy link
Contributor

/approve
/hold
If @zhzhuang-zju want to review again.

Thanks for your contribution!

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.21%. Comparing base (0aa91d8) to head (2a35dfb).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5137   +/-   ##
=======================================
  Coverage   28.21%   28.21%           
=======================================
  Files         632      632           
  Lines       43568    43568           
=======================================
  Hits        12291    12291           
+ Misses      30381    30380    -1     
- Partials      896      897    +1     
Flag Coverage Δ
unittests 28.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor

@zhzhuang-zju Sorry for creating multiple PR's and then closing them, I made some mistakes while resolving the conflicts.

It's okay, you'll know how to handle this situation a few more times. Here is how I handle it if you decide it's useful

  • git fetch upstream master
  • git reset --hard upstream/master
  • git pull upstream master # now your local code is up-to-date
  • Modify the code, followed by the normal process of submitting the code, just the last git push with -f

@zhzhuang-zju
Copy link
Contributor

/lgtm
@liangyuanpeng

@liangyuanpeng
Copy link
Contributor

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2024
@aditya7302
Copy link
Contributor Author

@zhzhuang-zju Sorry for creating multiple PR's and then closing them, I made some mistakes while resolving the conflicts.

It's okay, you'll know how to handle this situation a few more times. Here is how I handle it if you decide it's useful

  • git fetch upstream master
  • git reset --hard upstream/master
  • git pull upstream master # now your local code is up-to-date
  • Modify the code, followed by the normal process of submitting the code, just the last git push with -f

Thanks @zhzhuang-zju I will make sure to follow these steps in the future.

@karmada-bot karmada-bot merged commit c4a81bf into karmada-io:master Jul 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants