-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define top level Permission for lint-chart.yaml (Chart Lint) workflow #5137
Conversation
Signed-off-by: aditya7302 <aditya7302@gmail.com>
@zhzhuang-zju Sorry for creating multiple PR's and then closing them, I made some mistakes while resolving the conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve Thanks for your contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangyuanpeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5137 +/- ##
=======================================
Coverage 28.21% 28.21%
=======================================
Files 632 632
Lines 43568 43568
=======================================
Hits 12291 12291
+ Misses 30381 30380 -1
- Partials 896 897 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It's okay, you'll know how to handle this situation a few more times. Here is how I handle it if you decide it's useful
|
/lgtm |
/hold cancel |
Thanks @zhzhuang-zju I will make sure to follow these steps in the future. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #5048
Special notes for your reviewer:
Does this PR introduce a user-facing change?: