-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt deprecated AddToScheme functions #5177
Adopt deprecated AddToScheme functions #5177
Conversation
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5177 +/- ##
==========================================
+ Coverage 28.22% 28.24% +0.02%
==========================================
Files 632 632
Lines 43566 43570 +4
==========================================
+ Hits 12296 12307 +11
+ Misses 30371 30366 -5
+ Partials 899 897 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/cc @chaunceyjiang
Let's do this as it is a blocker. @chaunceyjiang Please leave your comments here if there are any. By the way, I don't understand why the |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adopts the deprecated
AddToScheme
andSchemeGroupVersion
, which becomes the blocker of #5146.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is a kind of technical debt that I hope to do by a separate PR so that we can review it more carefully.
Does this PR introduce a user-facing change?: