-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue of residual work in the MultiClusterService feature. #5188
Fix the issue of residual work in the MultiClusterService feature. #5188
Conversation
51803e5
to
39cc1bd
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5188 +/- ##
==========================================
- Coverage 28.23% 28.23% -0.01%
==========================================
Files 632 632
Lines 43712 43713 +1
==========================================
- Hits 12344 12343 -1
- Misses 30465 30467 +2
Partials 903 903
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: changzhen <changzhen5@huawei.com>
39cc1bd
to
fc73d67
Compare
/cc @RainbowMango |
/cc @chaosi-zju |
/lgtm thanks |
So, before this fix introduced, if the deletion of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
It makes sense to append the finalizer during born.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…k-of-#5188-upstream-release-1.10 Automated cherry pick of #5188: Fix the issue of residual work in the MultiClusterService
…k-of-#5188-upstream-release-1.9 Automated cherry pick of #5188: Fix the issue of residual work in the MultiClusterService
…k-of-#5188-upstream-release-1.8 Automated cherry pick of #5188: Fix the issue of residual work in the MultiClusterService
What type of PR is this?
/kind bug
What this PR does / why we need it:
The finalizer
MCSEndpointSliceDispatchControllerFinalizer
was added too late, and when the dispatched work is still in the process of creating, deleting theMultiClusterService
object may result in residual dispatched work resources.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: