-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/e2e/karmadactl_test.go: test describe command #5191
test/e2e/karmadactl_test.go: test describe command #5191
Conversation
f63d13e
to
8cd2592
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5191 +/- ##
==========================================
+ Coverage 28.23% 28.25% +0.02%
==========================================
Files 632 632
Lines 43723 43723
==========================================
+ Hits 12345 12354 +9
+ Misses 30473 30467 -6
+ Partials 905 902 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! this looks good to me~
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
others LGTM
0ef3825
to
a29d595
Compare
I will ask for review when GitHub CI tests finish 👍 |
a29d595
to
ea8b18a
Compare
/lgtm |
This also needs rebase but let's merge those sequentially. Please ping me once it is time for merge so I rebase :) |
In this commit, we test `karmadactl describe` command on existing resource, non-existing resource, non-existing namespace, and invalid resource type. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
ea8b18a
to
ad1e76b
Compare
Rebased now. Will ask for review when the GitHub CI tests finish 👍 |
/assign |
@XiShanYongYe-Chang The GitHub CI tests are all finished and passed. I think it is ready for merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Vacant2333, XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Description
In this commit, we test
karmadactl describe
command on existing resource, non-existing resource, non-existing namespace, and invalid resource type.What type of PR is this?
/kind failing-test
Which issue(s) this PR fixes:
Part of #4544
Does this PR introduce a user-facing change?: