Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e/karmadactl_test.go: test describe command #5191

Merged
merged 1 commit into from
Jul 18, 2024
Merged

test/e2e/karmadactl_test.go: test describe command #5191

merged 1 commit into from
Jul 18, 2024

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we test karmadactl describe command on existing resource, non-existing resource, non-existing namespace, and invalid resource type.

What type of PR is this?

/kind failing-test

Which issue(s) this PR fixes:

Part of #4544

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jul 13, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 13, 2024
@mohamedawnallah mohamedawnallah force-pushed the testKarmadactlDescribeCommand branch 2 times, most recently from f63d13e to 8cd2592 Compare July 13, 2024 16:23
@mohamedawnallah mohamedawnallah mentioned this pull request Jul 13, 2024
Open
31 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2024 •
edited

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.25%. Comparing base (a87ec2a) to head (ad1e76b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5191      +/-   ##
==========================================
+ Coverage   28.23%   28.25%   +0.02%     
==========================================
  Files         632      632              
  Lines       43723    43723              
==========================================
+ Hits        12345    12354       +9     
+ Misses      30473    30467       -6     
+ Partials      905      902       -3
Flag Coverage Δ
unittests 28.25% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Vacant2333
Vacant2333 approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@Vacant2333 Vacant2333 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! this looks good to me~
/approve

zhzhuang-zju
zhzhuang-zju reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM

test/e2e/karmadactl_test.go Outdated Show resolved Hide resolved
@mohamedawnallah mohamedawnallah force-pushed the testKarmadactlDescribeCommand branch 2 times, most recently from 0ef3825 to a29d595 Compare July 15, 2024 04:40
@mohamedawnallah
Copy link
Contributor Author

I will ask for review when GitHub CI tests finish 👍

@zhzhuang-zju
Copy link
Contributor

/lgtm
thanks~ cc @Vacant2333 @XiShanYongYe-Chang

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
@mohamedawnallah
Copy link
Contributor Author

This also needs rebase but let's merge those sequentially. Please ping me once it is time for merge so I rebase :)

@mohamedawnallah
test/e2e/karmadactl_test.go: test describe command
ad1e76b 
In this commit, we test `karmadactl describe` command
on existing resource, non-existing resource, non-existing
namespace, and invalid resource type.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@mohamedawnallah
Copy link
Contributor Author

Rebased now. Will ask for review when the GitHub CI tests finish 👍

@XiShanYongYe-Chang
Copy link
Member

/assign

@mohamedawnallah
Copy link
Contributor Author

@XiShanYongYe-Chang The GitHub CI tests are all finished and passed. I think it is ready for merge :)

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Vacant2333, XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@XiShanYongYe-Chang
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
@karmada-bot karmada-bot merged commit 312d48f into karmada-io:master Jul 18, 2024
12 checks passed
@mohamedawnallah mohamedawnallah mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@zhzhuang-zju zhzhuang-zju zhzhuang-zju left review comments

@Vacant2333 Vacant2333 Vacant2333 approved these changes

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

@zhzhuang-zju zhzhuang-zju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mohamedawnallah @codecov-commenter @zhzhuang-zju @XiShanYongYe-Chang @karmada-bot @Vacant2333