Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e/karmadactl_test.go: test logs command #5195

Merged
merged 1 commit into from
Jul 17, 2024
Merged

test/e2e/karmadactl_test.go: test logs command #5195

merged 1 commit into from
Jul 17, 2024

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we test karmadactl logs command on existing cluster, existing pod, non-existing pod, non-existing cluster, and invalid input.

What type of PR is this?

/kind failing-test

Which issue(s) this PR fixes:

Part of #4544

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jul 13, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 13, 2024
@mohamedawnallah mohamedawnallah mentioned this pull request Jul 13, 2024
Open
31 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2024 •
edited

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.23%. Comparing base (d3adcf6) to head (09ec789).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5195      +/-   ##
==========================================
- Coverage   28.23%   28.23%   -0.01%     
==========================================
  Files         632      632              
  Lines       43712    43712              
==========================================
- Hits        12344    12341       -3     
- Misses      30465    30467       +2     
- Partials      903      904       +1
Flag Coverage Δ
unittests 28.23% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor

/retest

@mohamedawnallah
Copy link
Contributor Author

It seems the test cases passed the end-to-end tests for versions v1.29.0 and v1.30.0 after re-running them. Great 👍

@mohamedawnallah
Copy link
Contributor Author

mohamedawnallah commented Jul 15, 2024 •
edited

@zhzhuang-zju I addressed the same feedback same in other testing PRs regards utilizing public constants/methods. 👍

zhzhuang-zju
zhzhuang-zju reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
other LGTM

test/e2e/karmadactl_test.go Outdated Show resolved Hide resolved
test/e2e/karmadactl_test.go Show resolved Hide resolved
@mohamedawnallah
test/e2e/karmadactl_test.go: test logs command
09ec789 
In this commit, we test `karmadactl logs` command
on existing cluster, existing pod, non-existing pod,
non-existing cluster, and invalid input.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@zhzhuang-zju
Copy link
Contributor

/lgtm
cc @Vacant2333 @XiShanYongYe-Chang

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@karmada-bot karmada-bot merged commit 7f57502 into karmada-io:master Jul 17, 2024
12 checks passed
@mohamedawnallah mohamedawnallah mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@zhzhuang-zju zhzhuang-zju zhzhuang-zju left review comments

@Vacant2333 Vacant2333 Awaiting requested review from Vacant2333

Assignees

@zhzhuang-zju zhzhuang-zju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mohamedawnallah @codecov-commenter @zhzhuang-zju @karmada-bot @XiShanYongYe-Chang