-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/e2e/karmadactl_test.go: test logs command #5195
test/e2e/karmadactl_test.go: test logs command #5195
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5195 +/- ##
==========================================
- Coverage 28.23% 28.23% -0.01%
==========================================
Files 632 632
Lines 43712 43712
==========================================
- Hits 12344 12341 -3
- Misses 30465 30467 +2
- Partials 903 904 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest |
It seems the test cases passed the end-to-end tests for versions v1.29.0 and v1.30.0 after re-running them. Great 👍 |
134362e
to
573fb59
Compare
@zhzhuang-zju I addressed the same feedback same in other testing PRs regards utilizing public constants/methods. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
other LGTM
573fb59
to
99aee74
Compare
In this commit, we test `karmadactl logs` command on existing cluster, existing pod, non-existing pod, non-existing cluster, and invalid input. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
99aee74
to
09ec789
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot~
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we test
karmadactl logs
command on existing cluster, existing pod, non-existing pod, non-existing cluster, and invalid input.What type of PR is this?
/kind failing-test
Which issue(s) this PR fixes:
Part of #4544
Does this PR introduce a user-facing change?: