Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update karmada-apiserve and kube-controller-manager to v1.29.6 by default. #5209

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

liangyuanpeng
Copy link
Contributor

What type of PR is this?

/kind cleanup
What this PR does / why we need it:

Update karmada-apiserve and kube-controller-manager to v1.29.6 by default.

Karmada has been using karmada-apiserver v1.28.9 for a month and without any related issues. I think it’s time to upgrade to v1.29 to catch up with the corresponding version of kubernetes deps as soon as possible (currently 0.30)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-apiserver and kube-controller-manager is using v1.29.6 by default.

…ault.

Signed-off-by: Lan Liang <gcslyp@gmail.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 16, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 16, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.23%. Comparing base (8859cb9) to head (70cb862).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5209      +/-   ##
==========================================
- Coverage   28.25%   28.23%   -0.03%     
==========================================
  Files         632      632              
  Lines       43722    43722              
==========================================
- Hits        12354    12343      -11     
- Misses      30465    30474       +9     
- Partials      903      905       +2     
Flag Coverage Δ
unittests 28.23% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks.
We can update them to v1.30 in a couple of weeks, so that it follows the dependencies.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@karmada-bot karmada-bot merged commit 8736fae into karmada-io:master Jul 17, 2024
13 checks passed
@liangyuanpeng liangyuanpeng deleted the karmada_apiserver_1.29 branch July 17, 2024 02:08
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants