-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/e2e/karmadactl_test.go: test apply command #5250
test/e2e/karmadactl_test.go: test apply command #5250
Conversation
36d2e00
to
c9e06bd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5250 +/- ##
==========================================
+ Coverage 29.67% 29.82% +0.15%
==========================================
Files 632 632
Lines 43936 43936
==========================================
+ Hits 13037 13106 +69
+ Misses 29954 29873 -81
- Partials 945 957 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e7abd51
to
0ffe317
Compare
Trying to close the PR and re-open for flaky test cases e2e test (v1.30.0) to succeed! |
It seems all test cases passed now :) |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mohamedawnallah thanks your excellent work, and my opinion is for your consideration only.
PS. sorry for the late, I've been busy with other things lately, but I'll review your other PRs as soon as I can.
0ffe317
to
45d1499
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks~others LGTM
45d1499
to
ad13a46
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot~
In this commit, we add e2e tests for the `karmadactl apply` command to ensure it handles various scenarios correctly. The tests include: - Applying configurations without propagating them into member clusters. - Applying configurations with propagation into specific member clusters. - Applying configurations and propagating them to all member clusters. - Verifying that no resources were created during `--dry-run` mode. - Ensuring the command returns an error for an invalid flag. - Ensuring the command returns an error when the specified file does not exist. - Applying configurations with the `--namespace` flag to ensure resources are created in the specified namespace. - Applying configurations with the `--force-conflicts` flag to ensure conflicts are forcefully resolved during server-side apply. - Applying configurations using the `--kustomize` flag to process a kustomization directory. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com> Co-authored-by: zhzhuang-zju <m17799853869@163.com> Co-authored-by: Chang <changzhen5@huawei.com>
ad13a46
to
c325eee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we add e2e tests for the
karmadactl apply
command to ensure it handles various scenarios correctly. The tests include:--dry-run
mode.--namespace
flag to ensure resources are created in the specified namespace.--force-conflicts
flag to ensure conflicts are forcefully resolved during server-side apply.--kustomize
flag to process a kustomization directory.What type of PR is this?
/kind failing-test
Which issue(s) this PR fixes:
Part of #4544
Does this PR introduce a user-facing change?: