Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/e2e/karmadactl_test.go: test apply command #5250

Merged

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we add e2e tests for the karmadactl apply command to ensure it handles various scenarios correctly. The tests include:

  • Applying configurations without propagating them into member clusters.
  • Applying configurations with propagation into specific member clusters.
  • Applying configurations and propagating them to all member clusters.
  • Verifying that no resources were created during --dry-run mode.
  • Ensuring the command returns an error for an invalid flag.
  • Ensuring the command returns an error when the specified file does not exist.
  • Applying configurations with the --namespace flag to ensure resources are created in the specified namespace.
  • Applying configurations with the --force-conflicts flag to ensure conflicts are forcefully resolved during server-side apply.
  • Applying configurations using the --kustomize flag to process a kustomization directory.

What type of PR is this?

/kind failing-test

Which issue(s) this PR fixes:

Part of #4544

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jul 25, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 25, 2024
@mohamedawnallah mohamedawnallah force-pushed the testKarmadactlApplyCommand branch 3 times, most recently from 36d2e00 to c9e06bd Compare July 25, 2024 22:54
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.82%. Comparing base (6318541) to head (c325eee).
Report is 7 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5250      +/-   ##
==========================================
+ Coverage   29.67%   29.82%   +0.15%     
==========================================
  Files         632      632              
  Lines       43936    43936              
==========================================
+ Hits        13037    13106      +69     
+ Misses      29954    29873      -81     
- Partials      945      957      +12     
Flag Coverage Δ
unittests 29.82% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah mohamedawnallah force-pushed the testKarmadactlApplyCommand branch 2 times, most recently from e7abd51 to 0ffe317 Compare August 5, 2024 14:30
@mohamedawnallah
Copy link
Contributor Author

Trying to close the PR and re-open for flaky test cases e2e test (v1.30.0) to succeed!

@mohamedawnallah
Copy link
Contributor Author

It seems all test cases passed now :)

@zhzhuang-zju
Copy link
Contributor

/assign

Copy link
Contributor

@zhzhuang-zju zhzhuang-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohamedawnallah thanks your excellent work, and my opinion is for your consideration only.
PS. sorry for the late, I've been busy with other things lately, but I'll review your other PRs as soon as I can.

test/e2e/karmadactl_test.go Outdated Show resolved Hide resolved
test/e2e/karmadactl_test.go Outdated Show resolved Hide resolved
test/e2e/karmadactl_test.go Outdated Show resolved Hide resolved
test/e2e/karmadactl_test.go Outdated Show resolved Hide resolved
test/e2e/karmadactl_test.go Outdated Show resolved Hide resolved
test/e2e/karmadactl_test.go Outdated Show resolved Hide resolved
test/e2e/karmadactl_test.go Show resolved Hide resolved
test/e2e/karmadactl_test.go Outdated Show resolved Hide resolved
test/e2e/karmadactl_test.go Outdated Show resolved Hide resolved
test/e2e/karmadactl_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks~others LGTM

test/e2e/karmadactl_test.go Outdated Show resolved Hide resolved
@zhzhuang-zju
Copy link
Contributor

/lgtm
cc @XiShanYongYe-Chang

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~

test/e2e/karmadactl_test.go Outdated Show resolved Hide resolved
In this commit, we add e2e tests for the `karmadactl apply`
command to ensure it handles various scenarios correctly.
The tests include:

- Applying configurations without propagating them into member clusters.
- Applying configurations with propagation into specific member clusters.
- Applying configurations and propagating them to all member clusters.
- Verifying that no resources were created during `--dry-run` mode.
- Ensuring the command returns an error for an invalid flag.
- Ensuring the command returns an error when the specified file does not exist.
- Applying configurations with the `--namespace` flag to ensure resources are created in the specified namespace.
- Applying configurations with the `--force-conflicts` flag to ensure conflicts are forcefully resolved during server-side apply.
- Applying configurations using the `--kustomize` flag to process a kustomization directory.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
Co-authored-by: zhzhuang-zju <m17799853869@163.com>
Co-authored-by: Chang <changzhen5@huawei.com>
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2024
@karmada-bot karmada-bot merged commit 23cbfdc into karmada-io:master Aug 20, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants