Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the health probe argument of karmada-controller-manager #5290

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

seanlaii
Copy link
Contributor

@seanlaii seanlaii commented Aug 2, 2024

What type of PR is this?
/kind deprecation
/kind feature
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
part of #5219

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`:  Add health probe argument `health-probe-bind-address`, and deprecate `--bind-address` and `--secure-port` flag.

@karmada-bot karmada-bot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 2, 2024
@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 30.89%. Comparing base (98b2bda) to head (5d8c3a9).
Report is 2 commits behind head on master.

Files Patch % Lines
cmd/controller-manager/app/options/options.go 0.00% 7 Missing ⚠️
cmd/controller-manager/app/controllermanager.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5290   +/-   ##
=======================================
  Coverage   30.89%   30.89%           
=======================================
  Files         639      639           
  Lines       44343    44349    +6     
=======================================
+ Hits        13699    13703    +4     
- Misses      29664    29668    +4     
+ Partials      980      978    -2     
Flag Coverage Δ
unittests 30.89% <9.09%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whitewindmills
Copy link
Member

/ok-to-test
/retest

@whitewindmills
Copy link
Member

/retest

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Signed-off-by: wei-chenglai <qazwsx0939059006@gmail.com>
@RainbowMango
Copy link
Member

RainbowMango commented Aug 27, 2024

The failing test(chart testing) is due to the karmada-controller-manager can not recognize the --health-probe-bind-address flag. See logs here:

Error: unknown flag: --health-probe-bind-address

That is because the chart testing is against the latest image (not built from PR). (I'm surprised about this :().

So, for this PR, we can leave the chart unchanged and do it by another PR.

[edit]: chart testing need to be improved and just created an issue to track this.

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reverted changes of helm chart and we can bring it back after this.

/approve

@whitewindmills Do you want to take another look?

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@whitewindmills
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2024
@karmada-bot karmada-bot merged commit 9a678b6 into karmada-io:master Aug 27, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
@seanlaii seanlaii deleted the controller-manager-options branch September 11, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants