Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new command karmadactl create #5399

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

hulizhe
Copy link
Contributor

@hulizhe hulizhe commented Aug 19, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
add new command karmadactl create

$ karmadactl create ns test
namespace/test created
$ karmadactl get ns
NAME                 CLUSTER   STATUS   AGE     ADOPTION
... ...
test                 Karmada   Active   4s      N/A
$ karmadactl create -f sample-pod.yaml 
pod/nginx created
$ karmadactl get pods 
NAME    CLUSTER   READY   STATUS    RESTARTS   AGE
nginx   Karmada   0/1     Running   0          4s

Which issue(s) this PR fixes:
Parts of #5249

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`: add new command `create` to create a resource from a file or from stdin in Karmada control plane.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 19, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 19, 2024
@hulizhe hulizhe changed the title add new command karmadactl create [WIP]add new command karmadactl create Aug 19, 2024
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2024
Signed-off-by: hulizhe <pompeii.hu@gmail.com>
@hulizhe hulizhe changed the title [WIP]add new command karmadactl create add new command karmadactl create Aug 19, 2024
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 29.66%. Comparing base (c757122) to head (a6aa08e).

Files Patch % Lines
pkg/karmadactl/create/create.go 0.00% 5 Missing ⚠️
pkg/karmadactl/karmadactl.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5399      +/-   ##
==========================================
- Coverage   29.66%   29.66%   -0.01%     
==========================================
  Files         632      633       +1     
  Lines       43914    43920       +6     
==========================================
- Hits        13028    13027       -1     
- Misses      29943    29951       +8     
+ Partials      943      942       -1     
Flag Coverage Δ
unittests 29.66% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor

/retest

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@karmada-bot karmada-bot merged commit 6eb86ab into karmada-io:master Aug 26, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants