Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack/deploy-scheduler-estimator.sh support deploy estimator in the specified namespace #5511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Currently, the karmada-operator does not provide the capability to install the estimator, so it is often combined with hack/deploy-scheduler-estimator.sh to deploy karmada-scheduler-estimator. However, to better align hack/deploy-scheduler-estimator.sh with the installation method of the karmada-operator, we need to:

  • support deploy estimator in the specified namespace
  • GRPC certificate names can be configured to meet the needs of users who want to customize their certificate names.

Additionally, split the parameter MEMBER_CLUSTER_NAME into MEMBER_CLUSTER_CONTEXT and MEMBER_CLUSTER_NAME. Sometimes these two values are different and need to be distinguished.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

  • The new parameter is an optional parameter, and the default value remains unchanged
  • local test
  1. deploy karmada instance in test namespace
  2. join member cluster member1 with cluster context member1-host
  3. hack/deploy-scheduler-estimator.sh ~/.kube/karmada.config karmada-host ~/.kube/member1.config member1-host member1 test karmada-demo-cert
I0909 11:49:10.013859       1 cache.go:111] Start dialing estimator server(karmada-scheduler-estimator-member1.test.svc.cluster.local:10352) of cluster(member1).
I0909 11:49:10.044687       1 cache.go:119] Connection with estimator server(karmada-scheduler-estimator-member1.test.svc.cluster.local:10352) of cluster(member1) has been established.

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 10, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 10, 2024
@zhzhuang-zju
Copy link
Contributor Author

cc @jabellard

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.57%. Comparing base (6e41d9b) to head (14a8286).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5511   +/-   ##
=======================================
  Coverage   36.56%   36.57%           
=======================================
  Files         648      648           
  Lines       45079    45079           
=======================================
+ Hits        16485    16488    +3     
+ Misses      27351    27348    -3     
  Partials     1243     1243           
Flag Coverage Δ
unittests 36.57% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor Author

cc @chaosi-zju

@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2024
…ecified namespace

Signed-off-by: zhzhuang-zju <m17799853869@163.com>
@zhzhuang-zju
Copy link
Contributor Author

All the review comments have been addressed. Do you have any other comments?
cc @liangyuanpeng @chaosi-zju

@chaosi-zju
Copy link
Member

generally ok, see what other people think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants