-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack/deploy-scheduler-estimator.sh support deploy estimator in the specified namespace #5511
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @jabellard |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5511 +/- ##
=======================================
Coverage 36.56% 36.57%
=======================================
Files 648 648
Lines 45079 45079
=======================================
+ Hits 16485 16488 +3
+ Misses 27351 27348 -3
Partials 1243 1243
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cc @chaosi-zju |
f343d76
to
ccd6d6f
Compare
…ecified namespace Signed-off-by: zhzhuang-zju <m17799853869@163.com>
ccd6d6f
to
14a8286
Compare
All the review comments have been addressed. Do you have any other comments? |
generally ok, see what other people think |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently, the karmada-operator does not provide the capability to install the estimator, so it is often combined with
hack/deploy-scheduler-estimator.sh
to deploy karmada-scheduler-estimator. However, to better align hack/deploy-scheduler-estimator.sh with the installation method of the karmada-operator, we need to:Additionally, split the parameter
MEMBER_CLUSTER_NAME
intoMEMBER_CLUSTER_CONTEXT
andMEMBER_CLUSTER_NAME
. Sometimes these two values are different and need to be distinguished.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
test
namespacemember1
with cluster contextmember1-host
Does this PR introduce a user-facing change?: