-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standardize the naming of karmada secrets in operator method #5573
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5573 +/- ##
=======================================
Coverage 33.93% 33.93%
=======================================
Files 645 645
Lines 44857 44849 -8
=======================================
+ Hits 15220 15221 +1
+ Misses 28479 28471 -8
+ Partials 1158 1157 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
371eb31
to
ce7ee3f
Compare
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
ce7ee3f
to
4d827c4
Compare
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In karmada, here are two important secrets, which is mount by most karmada components. One is karmada-cert, which contains a series of cert files like ca.crt, apiserver.crt and so on; another is karmada-kubeconfig, which contains a kubeconfig of karmada-apiserver.
However, in different installation methods, we used inconsistent secret naming or file path naming, which can potentially cause some unnecessary problems, detail refer to #5363.
This PR aims to standardize the naming of karmada secrets in operator installation method.
Which issue(s) this PR fixes:
Fixes part of #5363
Special notes for your reviewer:
Does this PR introduce a user-facing change?: