-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fieldoverrider #5591
feat: add fieldoverrider #5591
Conversation
c352aae
to
181ab0f
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5591 +/- ##
==========================================
+ Coverage 35.23% 35.25% +0.01%
==========================================
Files 645 645
Lines 44891 44994 +103
==========================================
+ Hits 15817 15861 +44
- Misses 27841 27884 +43
- Partials 1233 1249 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
181ab0f
to
d118822
Compare
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cd7f9eb
to
283c732
Compare
@sophiefeifeifeiya Please rebase this PR to resolve the conflict. I just merged the API part at #5581. |
283c732
to
99cd82a
Compare
99cd82a
to
0722af4
Compare
1cf5323
to
6beb11c
Compare
ccc2364
to
c2486b6
Compare
d79631c
to
6bf7fbc
Compare
6bf7fbc
to
b397e6f
Compare
/cc @RainbowMango @XiShanYongYe-Chang PTAL. |
ff126f5
to
22e4db5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Thank you @sophiefeifeifeiya for your excellent job!
22e4db5
to
5132466
Compare
Signed-off-by: sophie <yl5357@columbia.edu>
5132466
to
6bf6f30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Patrick0308, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The proposal introduces a new feature that allows users to partially override values inside JSON and YAML fields. This is achieved using JSON patch operation. This design enables users to to override the values within JSON/YAML fields partially, rather than replacing a whole JSON/YAML fields with
PlaintextOverrider
. Currently,PlaintextOverrider
applies JSON patch operations to whole fields, rather than specific values within fields, making it unsuitable for cases where users need to override individual values within those fields.Which issue(s) this PR fixes:
Fixes #5330
Special notes for your reviewer:
Proposal: #5449
Related PR: #5329, #5581
Does this PR introduce a user-facing change?: