Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/README.md: redirect users to the latest karmada-operator released tag #5593

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Sep 23, 2024

Description

In this commit, we redirect users to the latest karmada-operator tag.

Motivation and Context

While unit testing the Karmada Init and DeInit in the operator package (#5613), following the docs I couldn't create karmada instance of the operator due to CRD Download Error. This PR improves the docs.

What type of PR is this?

/kind documentation

Which issue(s) this PR fixes:
Fixes #5578

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 23, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2024
@mohamedawnallah
Copy link
Contributor Author

cc: @chaosi-zju

@mohamedawnallah mohamedawnallah changed the title operator/README.md: redirect users to the latest operator tag operator/README.md: redirect users to the latest karmada-operator released tag Sep 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.87%. Comparing base (4c8bcd4) to head (5d806be).
Report is 36 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5593      +/-   ##
==========================================
+ Coverage   34.14%   34.87%   +0.73%     
==========================================
  Files         643      645       +2     
  Lines       44524    44833     +309     
==========================================
+ Hits        15203    15637     +434     
+ Misses      28165    27991     -174     
- Partials     1156     1205      +49     
Flag Coverage Δ
unittests 34.87% <ø> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chaosi-zju chaosi-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I much appreciated the quick fix!

operator/README.md Outdated Show resolved Hide resolved
operator/README.md Outdated Show resolved Hide resolved
Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@mohamedawnallah
Copy link
Contributor Author

Will ask for review when the GitHub CI tests finish :)

Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@karmada-bot karmada-bot merged commit 5e36f17 into karmada-io:master Sep 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to Create Karmada Instance of the operator due to CRD Download Error (404)
6 participants