operator/pkg: mitigate null pointer dereference in Validate() and newRunData() functions
#5617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we mitigate the null pointer dereference issue in the deinit operator pkg by adding defensive checks on `opt.Karmada.Spec.HostCluster` in `newRunData` func and on `opt.Karmada.Spec.Components` in `Validate` in `init.go`. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
karmada-bot
added
the
kind/cleanup
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
size/S
mohamedawnallah
changed the title
Validate and newRunDataValidate() and newRunData() functions
| @@ -65,6 +65,9 @@ func (opt *InitOptions) Validate() error { | |||
| return fmt.Errorf("unexpected invalid crds remote url %s", opt.CRDTarball.HTTPSource.URL) | |||
| } | |||
| } | |||
| if opt.Karmada == nil || opt.Karmada.Spec.Components == nil || opt.Karmada.Spec.Components.KarmadaAPIServer == nil { | |||
| return fmt.Errorf("invalid Karmada configuration: Karmada, Karmada components, and Karmada API server must be defined") | |||
| } | |||
There was a problem hiding this comment.
opt.Karmada.Spec.Components == nil
I'm curious why components are not allowed to be nil. From the API, it seems all fields are optional.
Do you know some background? @chaosi-zju
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this commit, we mitigate the null pointer dereference issue in the deinit operator pkg by adding defensive checks on
opt.Karmada.Spec.HostClusterinnewRunDatafunc and onopt.Karmada.Spec.ComponentsinValidateininit.go.Motivation and Context
While unit testing the Karmada Init and DeInit in the operator package (#5613), deliberately passing empty components on those fields triggers a null pointer exception error. This PR resolves this issue by adding defensive checks.
While testing
What type of PR is this?
/kind cleanup
Does this PR introduce a user-facing change?: