Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced descheduler leaderElection options including: --leader-elect-lease-duration, --leader-elect-renew-deadline, --leader-elect-retry-period, #5787

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

yanfeng1992
Copy link
Member

Signed-off-by: huangyanfeng huangyanfeng1992@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

descheduler add LeaderElection config

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-descheduler`: Introduced leaderElection options including: `--leader-elect-lease-duration`, `--leader-elect-renew-deadline`, `--leader-elect-retry-period`, the default value not changed compared to previous version.

Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 5, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 5, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 42.32%. Comparing base (e76ce63) to head (5dd6aba).
Report is 289 commits behind head on master.

Files with missing lines Patch % Lines
cmd/descheduler/app/options/options.go 0.00% 13 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5787      +/-   ##
==========================================
+ Coverage   34.14%   42.32%   +8.17%     
==========================================
  Files         643      656      +13     
  Lines       44522    55883   +11361     
==========================================
+ Hits        15204    23653    +8449     
- Misses      28162    30712    +2550     
- Partials     1156     1518     +362     
Flag Coverage Δ
unittests 42.32% <0.00%> (+8.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good to me.

Just noticed that this PR is based on the commit made nearly 2 months ago.
I'm curious why the following tests would be launched:

  • Operator / Test on Kubernetes (v1.30.0) (pull_request)
  • Operator / Test on Kubernetes (v1.31.0) (pull_request)
  • Operator / Test on Kubernetes (v1.29.0) (pull_request)

Given the tests against the PR, the tests-related work isn't included in this PR.
cc @zhzhuang-zju

@zhzhuang-zju
Copy link
Contributor

    git switch -
  
  Turn off this advice by setting config variable advice.detachedHead to false
  
  HEAD is now at 593c2cc19 Merge 5dd6abafb9de5605aebadde7406c4c781d426fb4 into ac589d6921d73136cc869e326ed8107ce5c990d7

https://github.com/karmada-io/karmada/actions/runs/11679088238/job/32519589508?pr=5787

When checking out the logs, the checkout operation merges the commits from the PR and the commits from the branch that triggers the workflow. As a result, this can trigger the operator test.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2024
@karmada-bot karmada-bot merged commit b3d3bcd into karmada-io:master Nov 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants