-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Golang version to v1.22.9 #5820
Conversation
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
Found a weird failing test:
But I can't reproduce it after several runs on my side. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5820 +/- ##
=======================================
Coverage 44.84% 44.85%
=======================================
Files 658 658
Lines 53917 53917
=======================================
+ Hits 24180 24185 +5
+ Misses 28169 28165 -4
+ Partials 1568 1567 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I reproduce it on my side. It doesn't seem to be relevant to the current pr, because this error also occurs on the master branch. https://github.com/karmada-io/karmada/actions/runs/11851539681/job/33028378247 |
Yes, It seems not related, but it might be caused by Kubernetes dependencies update, I tracked this on #5796.
What do you think? Can we move this forward? |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Thist PR bump Golang to the latest v1.22 release.
Which issue(s) this PR fixes:
Part of #5796
Special notes for your reviewer:
Does this PR introduce a user-facing change?: