Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4451: enhanced forced deletion on karmadactl unjoin #5848

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Nov 20, 2024

Cherry pick of #4451 on release-1.11.
#4451: enhanced forced deletion on karmadactl unjoin
For details on the cherry pick process, see the cherry pick requests page.

`karmadactl`: The `--force` option of `unjoin` command now try to clean up resources propagated in member clusters.

Signed-off-by: zhzhuang-zju <m17799853869@163.com>
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 20, 2024
@chaosi-zju
Copy link
Member Author

cc @zhzhuang-zju

@zhzhuang-zju
Copy link
Contributor

/assign

@zhzhuang-zju
Copy link
Contributor

thanks~
/lgtm
/assign @RainbowMango

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 84 lines in your changes missing coverage. Please review.

Project coverage is 30.97%. Comparing base (80841d1) to head (6943601).

Files with missing lines Patch % Lines
pkg/karmadactl/util/cluster.go 0.00% 81 Missing ⚠️
pkg/karmadactl/unjoin/unjoin.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.11    #5848      +/-   ##
================================================
- Coverage         31.01%   30.97%   -0.05%     
================================================
  Files               643      644       +1     
  Lines             54205    54259      +54     
================================================
- Hits              16814    16809       -5     
- Misses            36361    36419      +58     
- Partials           1030     1031       +1     
Flag Coverage Δ
unittests 30.97% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@karmada-bot karmada-bot merged commit 3d1aa2f into karmada-io:release-1.11 Nov 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants