-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/karmadactl/util: unit test apiclient #5869
pkg/karmadactl/util: unit test apiclient #5869
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5869 +/- ##
==========================================
+ Coverage 48.10% 48.18% +0.07%
==========================================
Files 663 664 +1
Lines 54769 54803 +34
==========================================
+ Hits 26349 26405 +56
+ Misses 26711 26684 -27
- Partials 1709 1714 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest |
514d62c
to
6651ccd
Compare
In this commit, we unit test apiclient on creating restconfig. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
6651ccd
to
6ae8cfd
Compare
/lgtm |
Thanks guys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unit test the apiclient to verify the creation of a restconfig in both scenarios: when it exists and when it doesn't.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Does this PR introduce a user-facing change?: