Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/karmadactl: unit test unjoin #5870

Merged

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we unit test unjoining cluster by validating the unjoin cluster operation on arguments passed and by verifying the deletion of all resources on the unjoining cluster in case of cluster kubeconfig passed.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.61%. Comparing base (616a95e) to head (4e52374).

Files with missing lines Patch % Lines
pkg/karmadactl/unjoin/unjoin.go 69.23% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5870      +/-   ##
==========================================
+ Coverage   47.52%   47.61%   +0.08%     
==========================================
  Files         663      663              
  Lines       54755    54761       +6     
==========================================
+ Hits        26025    26073      +48     
+ Misses      27032    26980      -52     
- Partials     1698     1708      +10     
Flag Coverage Δ
unittests 47.61% <69.23%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

In this commit, we unit test unjoining cluster by
validating the unjoin cluster operation on arguments passed and
by verifying the deletion of all resources on the unjoining cluster
in case of cluster kubeconfig passed.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@karmada-bot karmada-bot merged commit 9cf4646 into karmada-io:master Dec 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants