Added unit tests for the replica package in the estimator server #5898
Conversation
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/XL
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5898 +/- ##
==========================================
+ Coverage 46.28% 46.68% +0.40%
==========================================
Files 663 663
Lines 54762 54746 -16
==========================================
+ Hits 25344 25559 +215
+ Misses 27789 27545 -244
- Partials 1629 1642 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/assign |
Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com> Added unit tests for the replica package in the estimator server Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
anujagrawal699
force-pushed
the
addedTests-pkg/estimator/server/replica/replica.go
branch
from
cd15543 to
c25263c
Compare
|
Ask again for a review from @zhzhuang-zju /assign |
| replicaSets []*appsv1.ReplicaSet | ||
| } | ||
|
|
||
| func (m *mockReplicaSetNamespaceLister) List(selector labels.Selector) (ret []*appsv1.ReplicaSet, err error) { |
There was a problem hiding this comment.
This is a great mock function, and for these mocks, I'm wondering if in the future centralise them into a public test util file dedicated to providing mock staking capabilities externally.
There was a problem hiding this comment.
Yeah that makes sense, most mocks used in different packages are redundant. We can consider merging them in a single util file in the future.
There was a problem hiding this comment.
This would be a nice improvement to reflect our top-level design for testing, and to put parts of the framework into the public test package of the entire repository, looking forward to this pr.
There was a problem hiding this comment.
This would be a nice improvement to reflect our top-level design for testing
agree
There was a problem hiding this comment.
We'll open a separate issue for it in future.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Description:
This PR adds comprehensive unit tests for the replica package in the estimator server. The tests cover all functions including GetUnschedulablePodsOfWorkload and podUnschedulable.
Additions:
Test Coverage:
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: