Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kind dependencis from v0.24.0 to v0.25.0 #5901

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

RainbowMango
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates sigs.k8s.io/kind to v0.25.0 whose default node image is Kubernetes v1.31.2.
Our E2E test uses kind to simulate clusters, and now we use the latest Kubernetes v1.31.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 2, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.48%. Comparing base (1bc955a) to head (addc75e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5901      +/-   ##
==========================================
- Coverage   46.49%   46.48%   -0.01%     
==========================================
  Files         663      663              
  Lines       54740    54740              
==========================================
- Hits        25450    25445       -5     
- Misses      27663    27667       +4     
- Partials     1627     1628       +1     
Flag Coverage Δ
unittests 46.48% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member Author

The failing test seems unrelated:

 Timeline >>
  STEP: Creating Remedy(remedy-bt4pv) @ 12/02/24 03:02:35.964
  STEP: update Cluster(member1) ServiceDomainNameResolutionReady condition to false @ 12/02/24 03:02:35.971
  STEP: wait Cluster(member1) status has TrafficControl RemedyAction @ 12/02/24 03:02:36.001
  STEP: remove Remedy resource @ 12/02/24 03:02:36.013
  STEP: wait Cluster(member1) status doesn't has TrafficControl RemedyAction @ 12/02/24 03:02:36.017
  [FAILED] in [It] - /home/runner/work/karmada/karmada/test/e2e/framework/cluster.go:308 @ 12/02/24 03:09:36.019
  << Timeline

  [FAILED] Timed out after 420.001s.
  Expected
      <bool>: false
  to equal
      <bool>: true
  In [It] at: /home/runner/work/karmada/karmada/test/e2e/framework/cluster.go:308 @ 12/02/24 03:09:36.019

  Full Stack Trace
    github.com/karmada-io/karmada/test/e2e/framework.WaitClusterFitWith({0x5e8b940, 0xc000619b00}, {0xc000a63b79, 0x7}, 0x5983180)
    	/home/runner/work/karmada/karmada/test/e2e/framework/cluster.go:308 +0x23e
    github.com/karmada-io/karmada/test/e2e.init.func10.1.3.4()
    	/home/runner/work/karmada/karmada/test/e2e/remedy_test.go:121 +0x78
    github.com/karmada-io/karmada/test/e2e.init.func10.1.3()
    	/home/runner/work/karmada/karmada/test/e2e/remedy_test.go:120 +0x3f1

/retest

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@RainbowMango RainbowMango added this to the v1.13 milestone Dec 2, 2024
@RainbowMango RainbowMango added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Dec 3, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit 7a9e4a1 into karmada-io:master Dec 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants