Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigs.k8s.io/metrics-server #5907

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

RainbowMango
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PRs updates the sigs.k8s.io/metrcis-server, as we always ensure that all dependencies use a common Kubernetes version.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
As mentioned at kubernetes-sigs/metrics-server#1565 (comment), metrics-server probably not have a official version with Kubernetes v1.31 dependencies, so we use the pseudo version this time.

Does this PR introduce a user-facing change?:

NONE

…tes v1.31 but don't rely on Go 1.23

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 4, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 4, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.38%. Comparing base (93a68eb) to head (ce69be8).
Report is 12 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5907      +/-   ##
==========================================
+ Coverage   46.50%   47.38%   +0.88%     
==========================================
  Files         663      663              
  Lines       54740    54755      +15     
==========================================
+ Hits        25456    25946     +490     
+ Misses      27656    27118     -538     
- Partials     1628     1691      +63     
Flag Coverage Δ
unittests 47.38% <ø> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2024
@RainbowMango RainbowMango added this to the v1.13 milestone Dec 9, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit 2d6f998 into karmada-io:master Dec 9, 2024
18 checks passed
@RainbowMango RainbowMango deleted the pr_bump_metrics_server branch December 9, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants