Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5400, #5216 #5931

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Dec 10, 2024

Cherry pick of #5400, #5216 on release-1.10.
#5400: add new cluster condition: IncompleteAPIEnablements
#5216: skip the filter if the cluster is already in the list of scheduling result even if the API is missed
For details on the cherry pick process, see the cherry pick requests page.

`karmada-scheduler`: Avoid filtering out clusters if the API enablement is incomplete during re-scheduling.

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 10, 2024
Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the automated-cherry-pick-of-#5400-upstream-release-1.10 branch 2 times, most recently from 78b8801 to 0141d3a Compare December 10, 2024 06:51
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.50%. Comparing base (9ca973f) to head (6ab6fb6).

Files with missing lines Patch % Lines
...kg/controllers/status/cluster_status_controller.go 64.70% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #5931      +/-   ##
================================================
- Coverage         51.51%   51.50%   -0.02%     
================================================
  Files               260      260              
  Lines             25782    25795      +13     
================================================
+ Hits              13282    13285       +3     
- Misses            11766    11774       +8     
- Partials            734      736       +2     
Flag Coverage Δ
unittests 51.50% <64.70%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member Author

/retest

@whitewindmills
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
…omplete to prevent accidental removal.

Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the automated-cherry-pick-of-#5400-upstream-release-1.10 branch from 0141d3a to 6ab6fb6 Compare December 10, 2024 11:27
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang changed the title Automated cherry pick of #5400: add new cluster condition: IncompleteAPIEnablements Automated cherry pick of #5400, #5216 Dec 10, 2024
@whitewindmills
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@karmada-bot karmada-bot merged commit db098b7 into karmada-io:release-1.10 Dec 11, 2024
12 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the automated-cherry-pick-of-#5400-upstream-release-1.10 branch December 12, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants