Introduced version command to karmada-controller-manager #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
kind/feature
|
@algebra2k Could please take a look? |
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
RainbowMango
force-pushed
the
pr_add_version_command
branch
from
0f2345d
to
239d94b
Compare
I have just looked at the sharecommand implementation. It's good idea. |
5 tasks
RainbowMango
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@algebra2k thanks for your time. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
$ ./karmada-controller-manager version karmada-controller-manager version: version.Info{GitVersion:"v0.8.0-105-g0f2345d", GitCommit:"0f2345d7f17d8aec16d53feaa53636b76684f3c4", GitTreeState:"clean", BuildDate:"2021-09-11T07:18:24Z", GoVersion:"go1.16.7", Compiler:"gc", Platform:"linux/amd64"}Which issue(s) this PR fixes:
Part of #716
Special notes for your reviewer:
Does this PR introduce a user-facing change?: