Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: translate zh/tutorials/access-service-across-clusters #607

Merged
merged 1 commit into from
May 22, 2024
Merged

doc: translate zh/tutorials/access-service-across-clusters #607

merged 1 commit into from
May 22, 2024

Conversation

B1F030
Copy link
Contributor

@B1F030 B1F030 commented May 21, 2024

What type of PR is this?
/kind documentation

What this PR does / why we need it:
translate zh/tutorials/access-service-across-clusters

Which issue(s) this PR fixes:

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 21, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 21, 2024
windsonsea
windsonsea reviewed May 22, 2024
View reviewed changes
docs/tutorials/access-service-across-clusters.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/access-service-across-clusters.md
@@ -1,45 +1,45 @@
---
title: Access service across clusters within native service
title: 通过原生 Service 跨集群访问服务
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Service 译与不译怎么界定的，怎么让后来者更容易理解和传承？

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the resource names native to k8s or karmada can be left untranslated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我认为需要结合上下文考虑：

  • 当原文中的 service 特指 Service 这个资源对象的时候，不译；
  • 当原文中的 service 代表不特定的，抽象的服务时，就需要翻译；

比如此处的这一句，native service 指代原生的 Service 资源对象，则不译，Access service across clusters 是指跨集群访问服务，并不特指 Service 资源对象，更像是一个抽象的概括，就可以翻译；另外从语句整体考虑，此处不管是两个都译，还是两个都不译，都有点语意冲突容易让人混淆，因此区分翻译也有助于读者理解。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把不译的 Service，在英文文档也写成首字母大写 Service 呢，这样可以区分一下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

docs/tutorials/access-service-across-clusters.md Show resolved Hide resolved
zhzhuang-zju
zhzhuang-zju reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM

i18n/zh/docusaurus-plugin-content-docs/current/tutorials/access-service-across-clusters.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/access-service-across-clusters.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/access-service-across-clusters.md Outdated Show resolved Hide resolved
docs/tutorials/access-service-across-clusters.md Show resolved Hide resolved
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 22, 2024
@B1F030
translate zh/tutorials/access-service-across-clusters
bdb84d0 
Signed-off-by: B1F030 <b1fzhang@gmail.com>
windsonsea
windsonsea reviewed May 22, 2024
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the en text

@zhzhuang-zju
Copy link
Contributor

/lgtm
cc @RainbowMango

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
RainbowMango
RainbowMango approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
@karmada-bot karmada-bot merged commit c76b569 into karmada-io:main May 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhzhuang-zju zhzhuang-zju zhzhuang-zju left review comments

@windsonsea windsonsea windsonsea left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@Tingtal Tingtal Awaiting requested review from Tingtal

Assignees

@zhzhuang-zju zhzhuang-zju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@B1F030 @zhzhuang-zju @karmada-bot @RainbowMango @windsonsea