Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: translate zh/installation/ha-installation #609

Merged
merged 1 commit into from
May 24, 2024

Conversation

B1F030
Copy link
Contributor

@B1F030 B1F030 commented May 23, 2024

What type of PR is this?
/kind documentation

What this PR does / why we need it:
translate zh/installation/ha-installation

Which issue(s) this PR fixes:

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 23, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 23, 2024
@B1F030
Copy link
Contributor Author

B1F030 commented May 24, 2024

/cc @zhzhuang-zju

Copy link
Contributor

@zhzhuang-zju zhzhuang-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done~ others LGTM
cc @windsonsea for another look

Signed-off-by: B1F030 <b1fzhang@gmail.com>
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm


因此,为了构建堆叠式高可用集群,您应该至少运行三个堆叠式的控制平面节点。

![Karmada stacked etcd](../resources/general/karmada-stacked-etcd.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can suggest the original authors to provide .svg images, if any, which would be helpful for translation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@karmada-bot karmada-bot merged commit 86a60fd into karmada-io:main May 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants