Update the documentation to reflect deprecation of "external" profile value in istioctl
#620
Conversation
Signed-off-by: devleejb <devleejb@gmail.com>
karmada-bot
added
the
kind/documentation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
size/L
|
@windsonsea |
docs/userguide/service/working-with-istio-on-non-flat-network.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael <haifeng.yao@daocloud.io>
| @@ -12,11 +12,13 @@ not direct connectivity between the pods in all clusters. | |||
|  | |||
|
|
|||
| *** | |||
There was a problem hiding this comment.
Can you remind me why change this *** to ---, seems they are both used to add a new line.
I'm ok with it, it seems this one forgot to change.
There was a problem hiding this comment.
It is just because of markdown formatter in my editor.
There was a problem hiding this comment.
Is there a good reason to do this? Is there some explanation from your editor?
I'm not sure if another editor would change this back :)
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR updates the documentation to reflect the deprecation of the "external" profile value in
istioctland its replacement with "remote" to align with the latest changes.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: