Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File paths for EDB configurations are wrongly interpreted on Windows #97

Closed
irina-dragoste opened this issue Aug 27, 2022 · 3 comments
Closed
Labels

Comments

@irina-dragoste
Copy link
Collaborator

irina-dragoste commented Aug 27, 2022

For an EDB.config file on a Windows machine

EDB0_predname=r-1
EDB0_type=INMEMORY
EDB0_param0=D:\rulewerk\rulewerk-vlog\src\test\data\input
EDB0_param1=constantD

I get the following error when reasoning with any rule with EDB predicate name r-:

[0xf66f28325ab80c29 2022-08-27 21:14:20] ERROR  While importing data for predicate "r-1": could not open file /D:\rulewerk\rulewerk-vlog\src\test\data\input/constantD.nt nor /D:\rulewerk\rulewerk-vlog\src\test\data\input/constantD.csv nor gzipped versions

The path VLog should look for instead would be D:\rulewerk\rulewerk-vlog\src\test\data\input\constantD.nt

In noticed this problem because Rulewerk unit tests are failing on Windows due to this bug (ex: VLogReasonerStateTest#testResetKeepExplicitDatabase() )

If this fix requires a lot of changes anyway, it would perhaps be more maintainable if the EDB configuration would have a single parameter containing the path to the file, instead of the parent directory and the file name (without extension) as separate parameters.

CerielJacobs added a commit that referenced this issue Aug 29, 2022
@CerielJacobs
Copy link
Contributor

I think I fixed this. Can you please try it with attached jar?
jvlog-local.zip

@irina-dragoste
Copy link
Collaborator Author

I think I fixed this. Can you please try it with attached jar? jvlog-local.zip

It works, thank you!

@CerielJacobs
Copy link
Contributor

Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants