Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ttl argument to BaseStorage class #94

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

karpetrosyan
Copy link
Owner

Because all storages must implement time to leave logic, the ttl argument was moved to the base class.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #94 (7da82dc) into master (c1daff4) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 7da82dc differs from pull request most recent head e3e7d5d. Consider uploading reports for the commit e3e7d5d to get more accurate results

@@            Coverage Diff            @@
##            master       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         1667      1666    -1     
=========================================
- Hits          1667      1666    -1     
Files Coverage Δ
hishel/_async/_storages.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@karpetrosyan karpetrosyan merged commit 2af3363 into master Oct 25, 2023
@karpetrosyan karpetrosyan mentioned this pull request Oct 25, 2023
@karpetrosyan karpetrosyan added the enhancement New feature or request label Oct 25, 2023
@karpetrosyan karpetrosyan deleted the make-ttl-base-argument branch November 22, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant