Fix tests

karthiknadig · Aug 29, 2023 · a545e36 · a545e36
1 parent 6d09733
commit a545e36
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/client/pythonEnvironments/creation/provider/condaCreationProvider.ts b/src/client/pythonEnvironments/creation/provider/condaCreationProvider.ts
@@ -128,7 +128,9 @@ async function createCondaEnv(
             dispose();
             if (proc?.exitCode !== 0) {
                 traceError('Error while running venv creation script: ', progressAndTelemetry.getLastError());
-                deferred.reject(progressAndTelemetry.getLastError());
+                deferred.reject(
+                    progressAndTelemetry.getLastError() || `Conda env creation failed with exitCode: ${proc?.exitCode}`,
+                );
             } else {
                 deferred.resolve(condaEnvPath);
             }

diff --git a/src/test/pythonEnvironments/creation/provider/condaCreationProvider.unit.test.ts b/src/test/pythonEnvironments/creation/provider/condaCreationProvider.unit.test.ts
@@ -185,7 +185,8 @@ suite('Conda Creation provider tests', () => {
         assert.isDefined(_error);
         _error!('bad arguments');
         _complete!();
-        await assert.isRejected(promise);
+        const result = await promise;
+        assert.ok(result?.error);
         assert.isTrue(showErrorMessageWithLogsStub.calledOnce);
     });
 
@@ -241,7 +242,8 @@ suite('Conda Creation provider tests', () => {
 
         _next!({ out: `${CONDA_ENV_CREATED_MARKER}new_environment`, source: 'stdout' });
         _complete!();
-        await assert.isRejected(promise);
+        const result = await promise;
+        assert.ok(result?.error);
         assert.isTrue(showErrorMessageWithLogsStub.calledOnce);
     });
 });