Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove "time" field from dataset if no time column exists #429

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

osundwajeff
Copy link
Contributor

@osundwajeff osundwajeff commented Feb 10, 2025

@osundwajeff osundwajeff linked an issue Feb 10, 2025 that may be closed by this pull request
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
16327 15375 94% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 49a88dc by action🐍

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.04%. Comparing base (dad4f7e) to head (49a88dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files         259      259           
  Lines       15841    15845    +4     
=======================================
+ Hits        14898    14902    +4     
  Misses        943      943           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@danangmassandy danangmassandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osundwajeff the to_json code is in ObservationParquetReaderValue and it's not calling to_json in parent class. So your change is not called by ObservationParquetReaderValue. Have you tested your changes? you can use arable parquet data in staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arable json export issues
2 participants