Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work2 #283

Merged
merged 17 commits into from
Feb 14, 2022
Merged

Work2 #283

merged 17 commits into from
Feb 14, 2022

Conversation

dhardy
Copy link
Collaborator

@dhardy dhardy commented Feb 14, 2022

Improve margins:

  • separate horiz/vert margins for text
  • ensure EditBox has interior margins
  • menu entries use interior margins, not exterior
  • add PopupFrame to fix positioning of pop-up menus
  • tweak menu graphics

Add FrameStyle enum to reduce the size of the themed size/draw API. Motivation is mixed:

  • SizeMgr, SizeHandle, DrawMgr, DrawHandle, layout::Layout all get simpler APIs
  • This could be useful for code-share in theme implementations, but current implementations are too dissimilar to benefit much
  • This approach means that adding new feature variants to the theme API has low cost

Do not use CursorIcon::Grabbing in a non-scrollable scroll-region (e.g. in the Gallery when scrollbars are not visible).

dhardy added 17 commits February 13, 2022 15:43
@dhardy
Use kas-text 0.4.2
85feb2f
@dhardy
Better "Wakeup: timer" log message
73e9586
@dhardy
Use separate horizontal/vertical margins for text
c05dfad
@dhardy
Better menu frames
0cd4d44
@dhardy
EditBox: fix interior margins
e4f92c4
@dhardy
Add kas_core::theme::FrameStyle to compress size/draw API
b6a9f69
@dhardy
Add PopupFrame; fix position of popups wrt own frame
9216bc2
@dhardy
FlatTheme: draw popup frame inside menu entry
fd40499 
Looks better, at the cost of assumptions about which widgets
are used in the popup!
@dhardy
Add menu_frame dimension parameter
0334deb
@dhardy
Add FrameStyle::InnerMargin
2f84170
@dhardy
Remove frame margin
0d4473b
@dhardy
EditBox: use layout visitor
0d8db33
@dhardy
Frame/Popup/Button: ignore content margin
d6ca6ab 
Mostly because it's confusing when putting an Image inside
a Frame increases the Frame's margin.
@dhardy
ScrollComponent: ignore PressStart when unable to scroll
99024ab
@dhardy
ScrollComponent::scroll_by_event: in-line closure
c3c25a8 
This simplifies uses which are all identical.
@dhardy
TextInput component: use CursorIcon::Grabbing for scrolling
806ffa7
@dhardy
Geometry types: fix and move winit impls to submodule
3111e97
@dhardy dhardy merged commit a81610c into master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dhardy