Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacks for usage with stable Rust #30

Closed
wants to merge 2 commits into from
Closed

Hacks for usage with stable Rust #30

wants to merge 2 commits into from

Conversation

dhardy
Copy link
Collaborator

@dhardy dhardy commented Dec 17, 2019

This puts proc-macro diagnostics behind a feature gate, and uses proc-macro-hack to avoid a requirement on proc_macro_hygiene.

Fixes #25.

I am unsure whether to merge this. As nice as it is to be able to use stable Rust, it hides macro diagnostics by default, uglifies the code-base (especially with make_widget having to be exported from the root of kas), and examples need high macro recursion limits:

// calculator.rs
#![recursion_limit = "1024"]

@dhardy
Copy link
Collaborator Author

dhardy commented Jul 17, 2020

This is now completely obsolete (thanks Rust 1.45 🎉).

@dhardy dhardy closed this Jul 17, 2020
@dhardy dhardy deleted the proc-macro-hack branch July 22, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly feature usage
1 participant