Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll bars in EditBox and ScrollLabel; DragHandle → GripPart, update KAS-text #339

Merged
merged 19 commits into from
Jul 27, 2022
Merged

Scroll bars in EditBox and ScrollLabel; DragHandle → GripPart, update KAS-text #339

merged 19 commits into from
Jul 27, 2022

Conversation

dhardy
Copy link
Collaborator

@dhardy dhardy commented Jul 26, 2022 •
edited
Loading

  • Rename DragHandle → GripPart
  • GripPart: clamp output to valid range before sending as message (partial revert)
  • Add enum GripMsg, struct ScrollMsg(pub i32)
  • Swap EditField::on_* argument order for consistency with other methods
  • Add EditBox::empty and EditField::empty constructors
  • Add a scroll bar to EditBox and ScrollLabel (vertical only, invisible for ScrollLabel, not configurable). The exact API may be adjusted in the future, but this at least adds an expected feature.
  • Add SizeMgr::scroll_bar_width since this value is needed in several places and extracting from size rules is annoying.
  • Update KAS-text — Input fixes #73 — this adds fonts::any_loaded and Text::try_prepare
  • Remove set_text_and_prepare utility; KAS-text now provides set_and_try_prepare as a replacement
  • Reduce scroll bar margin to 0

dhardy added 18 commits July 25, 2022 11:34
@dhardy
FnSizeRules: explicitly annotate lifetime bound
8c00558
@dhardy
Diagnostics for #[widget { .. }]: better context for missing ;
335d6aa
@dhardy
Fix internal_doc feature forwarding
3eedf0c
@dhardy
Replace DragHandle with GripPart and MsgPressFocus with GripMsg
cff96f4
@dhardy
ScrollBar: wrap message with ScrollMsg
677dab9
@dhardy
EditField::on_activate/on_afl/on_edit: swap arg order
c4c32f6 
Push `mgr: &mut EventMgr` first for consistency.
Note: arg order in EditGuard is already consistent since
arg `edit: &mut EditField<Self>` replaces `&mut self`.
@dhardy
Add EditBox/Field::empty (constructor without argument)
658b6ba
@dhardy
Doc: temporary nature of kas::model
5e545db
@dhardy
Clarification: Widget::translation only applies to children
85883cd 
(This is a necessary fix for next commits.)
@dhardy
Grip: output is clamped position
0c59144 
This results in a simpler, less error-prone API.
This is a partial revert of 320d46c.
@dhardy
ScrollLabel: add a scroll bar
5280528
@dhardy
ScrollLabel's scroll bar: make invisible
276735b
@dhardy
Update KAS-text regarding #73: InvalidFontId
16643c6
@dhardy
EditBox: remove methods redundant due to Deref[Mut]
7cebd9c
@dhardy
Add SizeMgr::scroll_bar_width
38f631f
@dhardy
Add SelectionHelper::set_max_len; use in EditField
7848974
@dhardy
EditBox: add a scroll bar
0b9d1ae
@dhardy
Reduce scroll bar margins to 0
6e78578
@dhardy dhardy changed the title DragHandle → GripPart; GripMsg, ScrollMsg; EditField::on_* arg order; EditBox::empty Scroll bars in EditBox and ScrollLabel; DragHandle → GripPart, update KAS-text Jul 27, 2022
@dhardy dhardy merged commit 4a95869 into master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dhardy