Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deref impls #465

Merged
merged 18 commits into from
Jan 9, 2025
Merged

Remove Deref impls #465

merged 18 commits into from
Jan 9, 2025

Conversation

dhardy
Copy link
Collaborator

@dhardy dhardy commented Jan 9, 2025

Remove Deref, DerefMut impls for all widgets with their own Id. This brings Kas more in-line with the Deref recommendations:

In general, deref traits should not be implemented if:
[..]
the type has methods that are likely to collide with methods on the target type;

There remains some potential for method collisions via Deref on Map and MapAny, but such cases should cause other errors due to the differing data type on the only methods which do not simply forward to the inner method anyway.

@dhardy dhardy merged commit f133edc into master Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant