data scraper, collected data #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karakean
approved these changes
Jun 8, 2024
filip-szweda
requested changes
Jun 8, 2024
scrapers/declension.py
Outdated
| if entry['partOfSpeech'] != "NOUN": | ||
| return | ||
|
|
||
| for meaning in meanings: |
There was a problem hiding this comment.
Please use helper functions, Python code shouldn't be as nested.
filip-szweda
reviewed
Sep 3, 2024
scrapers/declension.py
Outdated
| return {} | ||
|
|
||
| html_content = response.content | ||
| soup = BeautifulSoup(html_content, 'html.parser') |
There was a problem hiding this comment.
Suggested change
| soup = BeautifulSoup(html_content, 'html.parser') | |
| parsed_html = BeautifulSoup(html_content, 'html.parser') |
| soup = BeautifulSoup(html_content, 'html.parser') | ||
| declension_table = soup.find('table') | ||
|
|
||
| if not declension_table: |
There was a problem hiding this comment.
print("ERROR: Failed to find declension table in parsed html")
| url = f"{POLISH_NOUN_API_URL}{quoted_noun}" | ||
| response = requests.get(url) | ||
|
|
||
| if response.status_code != 200: |
There was a problem hiding this comment.
print(f"ERROR: Received status code {response.status_code}")
scrapers/declension.py
Outdated
| 'Wołacz': 'vocative' | ||
| } | ||
|
|
||
| rows = declension_table.find_all('tr')[1:] # skip header row |
There was a problem hiding this comment.
from bs4.element import Tag
...
def get_table_rows_excluding_header(table: Tag) -> Tag:
return table.find_all("tr")[1:]
Suggested change
| rows = declension_table.find_all('tr')[1:] # skip header row | |
| rows = get_table_rows_excluding_header(declension_table) |
scrapers/declension.py
Outdated
| } | ||
|
|
||
| case_mapping = { | ||
| 'Mianownik': 'nominative', |
filip-szweda
reviewed
Sep 7, 2024
| if entry['partOfSpeech'] != "NOUN": | ||
| return | ||
|
|
||
| for word_meaning in word_meanings: |
There was a problem hiding this comment.
Create KashubianEntryParser with following methods:
parse_word_meanings
parse_word_polish_translations
parse_noun_variations
parse_word_variations
parse_word_variation_variations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.