Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: make wren/run doesn't work #459

Open
bjchambers opened this issue Jun 28, 2023 · 4 comments
Open

bug: make wren/run doesn't work #459

bjchambers opened this issue Jun 28, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@bjchambers
Copy link
Collaborator

Description
As stated in CONTRIBUTING.md, the command make wren/run fails with the following error:
"unable to open database file: no such file or directory"
exit status 1
make: *** [wren/run] Error 1

This seems to be because the directory it creates the SQLite DB in doesn't exist. I fixed this by running mkdir tests/integration/data.

We should probably fix the documentation and/or ensure the directory exists before attempting to create the DB.
@bjchambers bjchambers added the bug Something isn't working label Jun 28, 2023
@bjchambers
Copy link
Collaborator Author

Also instructions for running integration tests using docker seem broken.

make test/int/docker-up

produces the following errors:

kaskada  | /bin/wren: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /bin/wren)
kaskada exited with code 1

@kevinjnguyen kevinjnguyen mentioned this issue Jun 28, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 28, 2023
@kevinjnguyen
bug: manager make directory for sqlite (#461)
dc5d791 
Fixes one issue in #459. Updates the dbpath logic to merge the provided
db path with the current path to produce an absolute path using the
`abs` ([docs](https://pkg.go.dev/path/filepath#Abs)).

Previously, we were only checking for the home directory and not
necessarily worrying about any other use cases. The logic proposed here
should merge the two flows.
@bjchambers
Copy link
Collaborator Author

Also, once the local binaries are running, things still fail since a Pulsar is necessary as well.

@jeffbanks
Copy link

Thanks @bjchambers for opening this issue. I ran into the same Pulsar missing issues today trying to setup a local dev environment.

@epinzur epinzur mentioned this issue Jul 10, 2023
Merged
@epinzur
Copy link
Collaborator

epinzur commented Jul 10, 2023

#490 should fix the creation of the sqlite and objectStore directories, and the GLIBC issue on Apple Silicon.

github-merge-queue bot pushed a commit that referenced this issue Jul 10, 2023
@epinzur
improved reliability of integration tests (#490)
f626c90 
resolves #474

progress on #473, #459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bjchambers @epinzur @jeffbanks