Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: using get with a list or index with a map panics #576

Closed
jordanrfrazier opened this issue Aug 1, 2023 · 0 comments · Fixed by #577
Closed

bug: using get with a list or index with a map panics #576

jordanrfrazier opened this issue Aug 1, 2023 · 0 comments · Fixed by #577
Assignees
@jordanrfrazier
Labels
bug Something isn't working sparrow

Comments

@jordanrfrazier
Copy link
Collaborator

jordanrfrazier commented Aug 1, 2023 •
edited
Loading

As the title says.

ListTable.string_list | get(0)


IPython.core.error.UsageError: An error occurred in your request.
	Error Code: INTERNAL
	Error Message: panic during prepare
Details: 
	request_id: "1130ef2952ebc65c63cbb6f144fea1d1"

Because we consider a list and map a FenlType::Collection -- both satisfy the type class. We should be checking explicitly whether the collection type applies to the signature.
@jordanrfrazier jordanrfrazier added bug Something isn't working sparrow labels Aug 1, 2023
@jordanrfrazier jordanrfrazier self-assigned this Aug 1, 2023
@jordanrfrazier jordanrfrazier mentioned this issue Aug 1, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 1, 2023
@jordanrfrazier
bug: fix default schema in inference for map/list (#577)
d5960e7 
Fixes the default schema for the `map` and `list` types in inference.
This isn't a good solution, as there's no guarantee that Arrow doesn't
change this behavior in the future. Ideally, we can figure out how to
plumb the user map type information through inference. But, it's
difficult because functions that produce `map` or `list` types need an
arbitrary naming/nullability that we define.

Closes #576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanrfrazier jordanrfrazier

Labels
bug Something isn't working sparrow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: fix default schema in inference for map/list kaskada-ai/kaskada
1 participant
@jordanrfrazier